Audit: Timestamps on sink entries should match the creation time of the audit event #26088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
core/audit
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
peteski22
requested review from
ccapurso,
biazmoreira,
VioletHynes,
marcboudreau and
kubawi
VioletHynes
approved these changes
Mar 22, 2024
| // to provide a formatted time. | ||
| type testTimeProvider struct{} | ||
|
|
||
| // formattedTime always returns the same value for 22nd March 2024 at 10:00:05 (and 10 nanos). |
There was a problem hiding this comment.
Environmental storytelling ;P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when entries for audit were written to configured sinks (file, socket, syslog) the time associated with each entry was related to the exact time the sink tried to write it, and not the time the audit entry itself was created.
This PR changes this so that the time the entry (audit event) is created is the time which appears in the sink logs, this will help Operators to coordinate entries across multiple audit device sinks.
Addresses #8466