Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-20396 Add limit of 100,000 to string templates #26110

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

VioletHynes
Copy link
Contributor

We now enforce a limit of 100,000 characters on string templates in the sdk/helpers library. This should be large enough to support almost all use cases, even if it is a change.

See Jira for further details.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 22, 2024
@VioletHynes VioletHynes marked this pull request as ready for review March 22, 2024 16:30
Copy link

github-actions bot commented Mar 22, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@divyaac divyaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@VioletHynes VioletHynes merged commit da00add into main Mar 25, 2024
92 of 99 checks passed
@VioletHynes VioletHynes deleted the violethynes/VAULT-20396 branch March 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants