Upgrade api package go-jose to v4 #26527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
swenson
reviewed
Apr 18, 2024
|
CI Results: |
|
OK we got some "good" failures :-) I'll push the proper fix now. For posterity: 
|
swenson
approved these changes
Apr 18, 2024
Yeah me too :-( unfortunately go-jose bumped their min version way up starting from v4: https://github.com/go-jose/go-jose/blob/v4.0.0/go.mod It's tempting to try to remove the dependency entirely given how little it's used in the package, but I didn't feel as confident about the risk involved for that route. |
|
Build Results: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/go-jose/go-jose/blob/main/CHANGELOG.md#changed for notes on the changes that necessitated v4 of
github.com/go-jose/go-jose. This upgrades to v4 so that other tools depending on theapipackage can avoid versions of the package with a CVE attached.The
apipackage only uses the dependency once (perhaps we should look into trimming that), but it does use a function whose signature has changed. We now need to provide the allowed signing algorithms when parsing a JWT.AFAICT, ES512 has been in use for over 5 years for signing JWTs associated with this
unwrapToken, so it should be the only algorithm we realistically need to support: https://github.com/hashicorp/vault/blame/1e36019f1c0f82e425661723f865fd7333225d6b/vault/wrapping.go#L221To help me gain confidence that the tests really were exercising this code path, I've initially committed support for the wrong algorithm. Locally, I've at least seen
TestPlugin_lifecycle/v4withinbuiltin/logical/databasefail with ES256 and pass with ES512 which seems to make sense. Hopefully that result is repeated for the full test suite in CI as well.