-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing delegated_auth_accessors config field to /sys/mounts/<path> response #26876
Merged
stevendpclark
merged 5 commits into
main
from
stevendpclark/vault-26906-return-delegated-auth
May 8, 2024
Merged
Add missing delegated_auth_accessors config field to /sys/mounts/<path> response #26876
stevendpclark
merged 5 commits into
main
from
stevendpclark/vault-26906-return-delegated-auth
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
May 8, 2024
- The field hadn't been properly populated in the JSON struct being returned through the API response, but had been properly set in the stored structs in the backend.
- Add missing update to the command tune docs for the -delegated-auth-accessors option that existed
- Add -delegated-auth-accessors to the secret enable vault command along with a docs update
…h> response - The field hadn't been properly populated in the JSON struct being returned through the API response, but had been properly set in the stored structs in the backend. - Add missing update to the command tune docs for the -delegated-auth-accessors option that existed - Add -delegated-auth-accessors to the secret enable vault command along with a docs update
CI Results: |
Build Results: |
victorr
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Left a question, but it does not necessarily warrant changes.
schavis
requested changes
May 8, 2024
2 tasks
Co-authored-by: Sarah Chavis <[email protected]>
schavis
approved these changes
May 8, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.