Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: remove stored token if cluster needs init #26985

Merged
merged 3 commits into from
May 13, 2024

Conversation

hashishaw
Copy link
Collaborator

@hashishaw hashishaw commented May 13, 2024

This PR prevents a rare edge case that makes the UI unusable, which happens when there is a token stored locally but the Vault cluster needs initialization. If this happens, the Vault UI will look like it's loading forever, while the network has a lot of failed API calls:

Example of bug

@hashishaw hashishaw added the ui label May 13, 2024
@hashishaw hashishaw added this to the 1.16.3 milestone May 13, 2024
@hashishaw hashishaw requested a review from a team as a code owner May 13, 2024 16:23
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 13, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange indeed. Thanks for addressing.

@hashishaw hashishaw merged commit 1fa8b1f into main May 13, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/VAULT-26930/prevent-ui-stuck-in-loading-state branch May 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants