Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash_algorithm parameter on Transit's verify HMAC requests. #27211

Merged

Conversation

victorr
Copy link
Contributor

@victorr victorr commented May 23, 2024

Parameter 'algorithm' has been deprecated in favour of 'hash_algorithm', so update the pathHMACVerify() handler to use it when it is present.

@victorr victorr added this to the 1.17.0 milestone May 23, 2024
@victorr victorr self-assigned this May 23, 2024
@victorr victorr requested a review from a team as a code owner May 23, 2024 20:56
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 23, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented May 23, 2024

Build Results:
All builds succeeded! ✅

Parameter 'algorithm' has been deprecated in favour of 'hash_algorithm', so
update the pathHMACVerify() handler to use it when it is present.
@victorr victorr force-pushed the victorr/vault-27444-hash-algorithm-on-transit-hmac-verify branch from 7ab0fb2 to af82ab3 Compare May 24, 2024 14:00
@victorr victorr added backport/1.15.x backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x and removed backport/1.15.x labels May 24, 2024
@victorr victorr merged commit 4173763 into main May 24, 2024
107 of 109 checks passed
@victorr victorr deleted the victorr/vault-27444-hash-algorithm-on-transit-hmac-verify branch May 24, 2024 15:12
@victorr victorr added backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent and removed backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants