Backport of UI: Fix client counts bug when no new clients into release/1.17.x #27385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-27818/no-new-clients-bug/eagerly-model-stinkbug
branch
from
430d9cf
to
76e68c5
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
hashishaw
approved these changes
Jun 6, 2024
|
CI Results: |
hashishaw
deleted the
backport/ui/VAULT-27818/no-new-clients-bug/eagerly-model-stinkbug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27352 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
If a user has clients, but no new clients registered for any months, the UI for client counts dashboard would break like this:
This PR addresses that scenario and adds testing. Due to the amount of changes in client counts between this release and previous, we will open bug fixes to the other releases manually.
Overview of commits