Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Allow creation of AWS session_token type role #27424

Merged
merged 2 commits into from
Jun 10, 2024
Merged

UI: Allow creation of AWS session_token type role #27424

merged 2 commits into from
Jun 10, 2024

Conversation

hashishaw
Copy link
Collaborator

This PR fixes a bug where choosing session_token type when creating a role broke the creation flow:
Kapture 2024-06-10 at 11 41 04

After fix:
Screenshot 2024-06-10 at 11 48 51

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x labels Jun 10, 2024
@hashishaw hashishaw added this to the 1.16.5 milestone Jun 10, 2024
@hashishaw hashishaw requested a review from a team as a code owner June 10, 2024 17:07
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

Monkeychip
Monkeychip approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@hashishaw hashishaw merged commit b0864e3 into main Jun 10, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/aws-create-session-token branch June 10, 2024 17:48
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.16.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hashishaw @Monkeychip