Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rotate root to the active node #27631

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

elliesterner
Copy link
Contributor

@elliesterner elliesterner commented Jun 27, 2024

Description

Force the rotate root (/sys/rotate) api call to the active node.
ENT portion which includes tests PR
JIRA reporting bug

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 27, 2024
@elliesterner elliesterner added backport/1.17.x backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jun 27, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jun 27, 2024

Build Results:
All builds succeeded! ✅

@elliesterner elliesterner added this to the 1.17.2 milestone Jun 27, 2024
@elliesterner elliesterner merged commit 76e3269 into main Jul 1, 2024
83 checks passed
@elliesterner elliesterner deleted the elliesterner/rotate-root-to-active branch July 1, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants