Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-28317 Update vault-hcp-lib to fix resource case bug #27694

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Jul 4, 2024

Description

This updates vault-hcp-lib to the latest version to include hashicorp/vault-hcp-lib#38 which fixes a bug in case handling. Further detail is in the linked PR but in short: we handled lowercasing incorrectly.

This should be backported to 1.17 and 1.16 but I'll do it manually since this will 100% fail if done automatically :P

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 4, 2024
@VioletHynes VioletHynes added this to the 1.18.0-rc milestone Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

CI Results:
All Go tests succeeded! ✅

@VioletHynes VioletHynes marked this pull request as ready for review July 4, 2024 16:14
Copy link

github-actions bot commented Jul 4, 2024

Build Results:
All builds succeeded! ✅

@VioletHynes VioletHynes requested a review from ccapurso July 5, 2024 12:53
@VioletHynes VioletHynes merged commit 6a083e7 into main Jul 5, 2024
92 of 119 checks passed
@VioletHynes VioletHynes deleted the violethynes/VAULT-28317 branch July 5, 2024 14:53
VioletHynes added a commit that referenced this pull request Jul 5, 2024
* VAULT-28317 Update vault-hcp-lib to fix resource case bug

* VAULT-28317 Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants