Experiment with disabling ASViewController background dealloc (Textur…

…eGroup#1420)
hebertialmeida · May 10, 2019 · b6a6b0f · b6a6b0f
1 parent d34a182
commit b6a6b0f
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 4 deletions.
diff --git a/Schemas/configuration.json b/Schemas/configuration.json
@@ -26,7 +26,8 @@
                     "exp_dispatch_apply",
                     "exp_image_downloader_priority",
                     "exp_text_drawing",
-                    "exp_fix_range_controller"
+                    "exp_fix_range_controller",
+                    "exp_oom_bg_dealloc_disable"
                 ]
     		}
 		}

diff --git a/Source/ASExperimentalFeatures.h b/Source/ASExperimentalFeatures.h
@@ -32,6 +32,7 @@ typedef NS_OPTIONS(NSUInteger, ASExperimentalFeatures) {
   ASExperimentalImageDownloaderPriority = 1 << 11,          // exp_image_downloader_priority
   ASExperimentalTextDrawing = 1 << 12,                      // exp_text_drawing
   ASExperimentalFixRangeController = 1 << 13,               // exp_fix_range_controller
+  ASExperimentalOOMBackgroundDeallocDisable = 1 << 14,      // exp_oom_bg_dealloc_disable
   ASExperimentalFeatureAll = 0xFFFFFFFF
 };
 

diff --git a/Source/ASExperimentalFeatures.mm b/Source/ASExperimentalFeatures.mm
@@ -25,7 +25,8 @@
                                       @"exp_dispatch_apply",
                                       @"exp_image_downloader_priority",
                                       @"exp_text_drawing",
-                                      @"exp_fix_range_controller"]));
+                                      @"exp_fix_range_controller",
+                                      @"exp_oom_bg_dealloc_disable"]));
   if (flags == ASExperimentalFeatureAll) {
     return allNames;
   }

diff --git a/Source/ASViewController.mm b/Source/ASViewController.mm
@@ -15,6 +15,8 @@
 #import <AsyncDisplayKit/ASTraitCollection.h>
 #import <AsyncDisplayKit/ASRangeControllerUpdateRangeProtocol+Beta.h>
 #import <AsyncDisplayKit/ASInternalHelpers.h>
+#import <AsyncDisplayKit/ASConfigurationInternal.h>
+#import <AsyncDisplayKit/ASExperimentalFeatures.h>
 
 @implementation ASViewController
 {
@@ -98,6 +100,9 @@ - (void)_initializeInstance
 
 - (void)dealloc
 {
+  if (ASActivateExperimentalFeature(ASExperimentalOOMBackgroundDeallocDisable)) {
+    return;
+  }
   ASPerformBackgroundDeallocation(&_node);
 }
 

diff --git a/Tests/ASConfigurationTests.mm b/Tests/ASConfigurationTests.mm
@@ -31,7 +31,8 @@
   ASExperimentalDispatchApply,
   ASExperimentalImageDownloaderPriority,
   ASExperimentalTextDrawing,
-  ASExperimentalFixRangeController
+  ASExperimentalFixRangeController,
+  ASExperimentalOOMBackgroundDeallocDisable
 };
 
 @interface ASConfigurationTests : ASTestCase <ASConfigurationDelegate>
@@ -57,7 +58,8 @@ + (NSArray *)names {
     @"exp_dispatch_apply",
     @"exp_image_downloader_priority",
     @"exp_text_drawing",
-    @"exp_fix_range_controller"
+    @"exp_fix_range_controller",
+    @"exp_oom_bg_dealloc_disable"
   ];
 }