feat: config i18n and language control #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellomuthu23
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request addresses issue #77, a suggestion about implementing i18n with JSON string texts.
The translation detects the browser language and starts with it or if have
?lng=enon params for example.🛠️ Changes made
react-i18nextand configure it.en-USandpt-BR.Toolbarto use the translation.🧪 Testing
LanguageComponent.Toolbartests for support i18n, not more usinggetByText.📸 Screenshots
ℹ️ Additional notes
getByText, we should pay attention when creating more translations like this one.