-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "T-Shirt and Numbers" option #88
Added "T-Shirt and Numbers" option #88
Conversation
675c3ee
to
931bb3f
Compare
931bb3f
to
72ceda1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @moritzluedtke. This option can be certainly useful for few users. Just need to add unit tests and test it in preview env.
Thanks for taking a look. I'll try to fix them soon. |
@hellomuthu23 I added some tests (should've done that in the first place) and fixed the broken one. |
I'd need some support with the failing workflow since I have no experience with your setup and Firebase. Looks like a config problem, though. |
yes, its a config problem. When the branch is not from actual source and the user doesn't have access to secrets. |
Ah, I see. Thanks for the explanation and the quick merging of my PR! |
no problem, thanks a lot for your contribution. Highly appreciated |
No description provided.