Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[concourse] Add service which targets prometheus port when prometheus metrics are enabled #6422

Closed
wants to merge 3 commits into from

Conversation

2color
Copy link
Contributor

@2color 2color commented Jul 2, 2018

What this PR does / why we need it:

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @2color. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 2color
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: william-tran

Assign the PR to them by writing /assign @william-tran in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2color
Copy link
Contributor Author

2color commented Jul 2, 2018

/assign @william-tran

@2color 2color changed the title Add service target prometheus port when prometheus metrics are enabled [concourse] Add service target prometheus port when prometheus metrics are enabled Jul 2, 2018
@2color 2color changed the title [concourse] Add service target prometheus port when prometheus metrics are enabled [concourse] Add service which targets prometheus port when prometheus metrics are enabled Jul 2, 2018
@william-tran
Copy link
Collaborator

Use a service instead of prometheus.io labels as recommended for prometheus-operator (prometheus-operator/kube-prometheus#16 (comment))

/cc @ebabani
Thoughts?

@k8s-ci-robot
Copy link
Contributor

@william-tran: GitHub didn't allow me to request PR reviews from the following users: ebabani.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Use a service instead of prometheus.io labels as recommended for prometheus-operator (prometheus-operator/kube-prometheus#16 (comment))

/cc @ebabani
Thoughts?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@william-tran
Copy link
Collaborator

Is a distinct service for prometheus necessary if we do #6338 instead? @2color @richardalberto I'm not a prometheus ops expert so I'm not sure what the best practice is.

@2color
Copy link
Contributor Author

2color commented Jul 16, 2018

Is a distinct service for prometheus necessary if we do #6338 instead? @2color @richardalberto I'm not a prometheus ops expert so I'm not sure what the best practice is.

#6338 should solve the problem. There's no real need for a distinct service. As long as the ingress doesn't expose it externally (which it doesn't as it specifies the port explicitly).

So I'm in favour of #6338

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants