-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[concourse] Add service which targets prometheus port when prometheus metrics are enabled #6422
Conversation
Hi @2color. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 2color Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @william-tran |
/cc @ebabani |
@william-tran: GitHub didn't allow me to request PR reviews from the following users: ebabani. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is a distinct service for prometheus necessary if we do #6338 instead? @2color @richardalberto I'm not a prometheus ops expert so I'm not sure what the best practice is. |
#6338 should solve the problem. There's no real need for a distinct service. As long as the ingress doesn't expose it externally (which it doesn't as it specifies the port explicitly). So I'm in favour of #6338 |
What this PR does / why we need it:
Special notes for your reviewer: