TECHDOCS-334-language-support #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nele Gross <[email protected]>
Signed-off-by: Nele Gross <[email protected]>
…amples TECHDOCS-1157 add instructions examples
dbacarel
requested changes
May 20, 2022
| @@ -1,6 +1,7 @@ | |||
| # Maps API for JavaScript | |||
|
|
|||
| This repository holds a series of JavaScript based examples using the **HERE Maps API for JavaScript**. More information about the API can be found on [developer.here.com](https://developer.here.com/develop/javascript-api) under the JavaScript APIs section. | |||
| This repository holds a series of JavaScript based examples using the **HERE Maps API for JavaScript**. More information about the API can be found on [developer.here.com](https://developer.here.com/develop/javascript-api) under the JavaScript APIs section. | |||
| To run the examples, clone this repo to a folder on your Desktop. Replace the credentials in the **test-credentials.js** file with your own credentials. | |||
There was a problem hiding this comment.
I would avoid giving direct instructions on where to clone the repo.
Therefore I would rephrase this like so:
Suggested change
| To run the examples, clone this repo to a folder on your Desktop. Replace the credentials in the **test-credentials.js** file with your own credentials. | |
| To run the examples, clone this repo and replace the credentials in the **test-credentials.js** file with your own credentials. |
| @@ -19,7 +19,7 @@ | |||
| <h1>Interactive base map</h1> | |||
| <p>Retrieve information associated with the map features</p> | |||
| </div> | |||
| <p>This example demonstrates how to enable the interactions with the base map features. The interactions are enabled for the countries' | |||
| <p>This example demonstrates how to enable the interactions with the base map features. See <a href="https://github.com/heremaps/maps-api-for-javascript-examples">the README</a> for instructions on how to run the example.The interactions are enabled for the countries' | |||
There was a problem hiding this comment.
Suggested change
| <p>This example demonstrates how to enable the interactions with the base map features. See <a href="https://github.com/heremaps/maps-api-for-javascript-examples">the README</a> for instructions on how to run the example.The interactions are enabled for the countries' | |
| <p>This example demonstrates how to enable the interactions with the base map features. See <a href="https://github.com/heremaps/maps-api-for-javascript-examples#maps-api-for-javascript">the README</a> for instructions on how to run the example. The interactions are enabled for the countries' |
What's the reason for adding this line only to this example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.