refactor: use typed namedtuples for the get_list
page result
#251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nice refactor that remove some magic from the
get_list
methods.The
get_list
function returns a named tuple that always has the following structure(result, meta)
. Since this is a tuple, we can unpack it without using the named attributes, and remove theresults_list_attribute_name
attributes used to access the data inside the tuple.NamedTuples
classes instead of dynamic (magic)namedtuples
for theget_list
PageResult
. This will greatly improve the library typing definition.