docs: cx11 is name, not an id #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 65 65
Lines 2883 2883
=======================================
Hits 2677 2677
Misses 206 206 ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
Apr 8, 2024
|
Always appreciated :) thanks |
jooola
pushed a commit
that referenced
this pull request
Jul 3, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.35.0...v2.0.0) (2024-07-03) ### ⚠ BREAKING CHANGES * return full rebuild response in `Client.servers.rebuild` ([#406](#406)) * make `datacenter` argument optional when creating a primary ip ([#363](#363)) * remove deprecated `include_wildcard_architecture` argument in `IsosClient.get_list` and `IsosClient.get_all` ([#402](#402)) * make `Client.request` `tries` a private argument ([#399](#399)) * make `Client.poll_interval` a private property ([#398](#398)) * return empty dict on empty responses in `Client.request` ([#400](#400)) * remove deprecated `hcloud.hcloud` module ([#401](#401)) * move `hcloud.__version__.VERSION` to `hcloud.__version__` ([#397](#397)) ### Features * add `trace_id` to API exceptions ([#404](#404)) ([8375261](8375261)) * allow using a custom poll_interval function ([#403](#403)) ([93eb56b](93eb56b)) * make `Client.poll_interval` a private property ([#398](#398)) ([d5f24db](d5f24db)) * make `Client.request` `tries` a private argument ([#399](#399)) ([428ea7e](428ea7e)) * move `hcloud.__version__.VERSION` to `hcloud.__version__` ([#397](#397)) ([4e3f638](4e3f638)), closes [#234](#234) * remove deprecated `hcloud.hcloud` module ([#401](#401)) ([db37e63](db37e63)) * remove deprecated `include_wildcard_architecture` argument in `IsosClient.get_list` and `IsosClient.get_all` ([#402](#402)) ([6b977e2](6b977e2)) * return empty dict on empty responses in `Client.request` ([#400](#400)) ([9f46adb](9f46adb)) * return full rebuild response in `Client.servers.rebuild` ([#406](#406)) ([1970d84](1970d84)) ### Bug Fixes * make `datacenter` argument optional when creating a primary ip ([#363](#363)) ([ebef774](ebef774)) ### Dependencies * update dependency coverage to >=7.5,<7.6 ([#386](#386)) ([5660691](5660691)) * update dependency mypy to >=1.10,<1.11 ([#387](#387)) ([35c933b](35c933b)) * update dependency myst-parser to v3 ([#385](#385)) ([9f18270](9f18270)) * update dependency pylint to >=3,<3.3 ([#391](#391)) ([4a6f005](4a6f005)) * update dependency pytest to >=8,<8.3 ([#390](#390)) ([584a36b](584a36b)) * update dependency sphinx to >=7.3.4,<7.4 ([#383](#383)) ([69c2e16](69c2e16)) * update pre-commit hook asottile/pyupgrade to v3.16.0 ([0ce5fbc](0ce5fbc)) * update pre-commit hook pre-commit/pre-commit-hooks to v4.6.0 ([5ef25ab](5ef25ab)) * update pre-commit hook psf/black-pre-commit-mirror to v24.4.0 ([0941fbf](0941fbf)) * update pre-commit hook psf/black-pre-commit-mirror to v24.4.1 ([fec08c5](fec08c5)) * update pre-commit hook psf/black-pre-commit-mirror to v24.4.2 ([#389](#389)) ([2b2e21f](2b2e21f)) * update pre-commit hook pycqa/flake8 to v7.1.0 ([3bc651d](3bc651d)) ### Documentation * add v2 upgrade notes ([#405](#405)) ([c77f771](c77f771)) * cx11 is name, not an id ([#381](#381)) ([b745d40](b745d40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make a real impact, as the
id_or_namemethod is called on the object later, but to be technically correct, it would be better to pass the server name asnameinstead ofid.