feat: add exponential and constant backoff function #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jooola
commented
Jul 19, 2024
jooola
commented
- Implement the same backoff function as in the hcloud-go libary
- Preparation work to change the retry backoff function to use an exponential backoff interval.
- Rename PollIntervalFunction to BackoffFunction, as it is not only used for polling.
jooola
force-pushed
the
backoff_functions
branch
from
5e4caca
to
7e6953f
Compare
jooola
force-pushed
the
backoff_functions
branch
from
7e6953f
to
638da80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 92.94% 92.94% -0.01%
==========================================
Files 64 64
Lines 2878 2891 +13
==========================================
+ Hits 2675 2687 +12
- Misses 203 204 +1 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Jul 22, 2024
jooola
pushed a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.1...v2.1.0) (2024-07-25) ### Features * add exponential and constant backoff function ([#416](#416)) ([fe7ddf6](fe7ddf6)) * deprecate `ServerType` `included_traffic` property ([#423](#423)) ([3d56ac5](3d56ac5)) * use exponential backoff when retrying requests ([#417](#417)) ([f306073](f306073)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.