-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement retry policy #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 93.10% 92.85% -0.26%
==========================================
Files 64 64
Lines 2960 2981 +21
==========================================
+ Hits 2756 2768 +12
- Misses 204 213 +9 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Aug 6, 2024
Co-authored-by: Julian Tölle <[email protected]>
jooola
pushed a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [2.2.0](v2.1.1...v2.2.0) (2024-08-06) ### Features * retry requests when the api gateway errors ([#430](#430)) ([f63ac8b](f63ac8b)) * retry requests when the api returns a conflict error ([#430](#430)) ([f63ac8b](f63ac8b)) * retry requests when the network timed outs ([#430](#430)) ([f63ac8b](f63ac8b)) * retry requests when the rate limit was reached ([#430](#430)) ([f63ac8b](f63ac8b)) ### Bug Fixes * update network subnet types ([#431](#431)) ([c32a615](c32a615)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a retry handler to retry requests based on an internal retry policy.
The retry policy will evolve over time to cover more use cases, but for now we want to start simple, and maybe someday allow users to tweak the retry policy.
Related to hetznercloud/hcloud-go#470
BEGIN_COMMIT_OVERRIDE
feat: retry requests when the api gateway errors (#430)
feat: retry requests when the network timed outs (#430)
feat: retry requests when the rate limit was reached (#430)
feat: retry requests when the api returns a conflict error (#430)
END_COMMIT_OVERRIDE