修复oracle审核正则匹配问题 #1169 #1194
Merged
修复oracle审核正则匹配问题 #1169 #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你好!感谢你反馈的问题/bug，但是你的描述好像是空的，我们需要你完整的信息，这样才能帮你解决问题 如果不知道怎么写，在新建issue的时候有若干个模板可供选择，祝好！ |
|
不知道咋回事 CI 没有跑起来, 有空我看看 |
|
ci应该坏了，看咋改成action |
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
=======================================
Coverage 77.91% 77.91%
=======================================
Files 76 76
Lines 11973 11973
=======================================
Hits 9329 9329
Misses 2644 2644
Continue to review full report at Codecov.
|
hhyo
previously approved these changes
Oct 19, 2021
hhyo
reviewed
Oct 19, 2021
sql/engines/oracle.py
Outdated
| @@ -225,15 +225,15 @@ def get_dml_table(sql='', object_name_list=None, db_name=''): | |||
| else: | |||
| return False | |||
| elif re.match(r"^delete", sql): | |||
| table_name = re.match(r"^delete\s+from\s(.+?)\s", sql, re.M).group(1) | |||
| table_name = re.match(r"^delete\s+from\s(.+?)", sql, re.M).group(1) | |||
There was a problem hiding this comment.
这个正则没有考虑存在where条件的场景，调整为delete\s+from\s(.+?)\s* 是不是更合适
There was a problem hiding this comment.
这个正则没有考虑存在where条件的场景，调整为
delete\s+from\s(.+?)\s*是不是更合适
delete\s+from\s(.+?)\s* 的话只能匹配到表名的第一个字符，改成 delete\s+from\s+([\w-]+)\s* 测试了下应该没问题了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
正则匹配问题 #1169
1.delete语句没有where条件时匹配不到最后一个空格
table_name = re.match(r"^delete\s+from\s(.+?)", sql, re.M).group(1)
2.同时发现insert语句漏匹配insert all when... into这种情况
table_name = re.match(r"^insert\s+((into)|(all\s+into)|(all\s+when\s(.+?)into))\s(.+?)((|\s)", sql, re.M).group(6)