Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oracle-数据字典兼容 #1351

Merged
merged 19 commits into from
Feb 17, 2022
Merged

Conversation

unknowissue
Copy link
Contributor

增加了Oracle的数据字典展示和导出功能

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #1351 (4b61051) into master (ca10a8f) will decrease coverage by 0.14%.
The diff coverage is 51.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   75.39%   75.24%   -0.15%     
==========================================
  Files          81       82       +1     
  Lines       12615    12927     +312     
==========================================
+ Hits         9511     9727     +216     
- Misses       3104     3200      +96     
Impacted Files Coverage Δ
sql/tests.py 98.97% <36.84%> (-1.03%) ⬇️
sql/data_dictionary.py 71.51% <54.54%> (-28.49%) ⬇️
sql/models.py 95.64% <0.00%> (ø)
sql/engines/clickhouse.py 71.20% <0.00%> (ø)
sql/engines/tests.py 99.83% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca10a8f...4b61051. Read the comment docs.

@unknowissue
Copy link
Contributor Author

Oracle的字段还需要再补充一下,以及Oracle的测试ci,晚点写。

@unknowissue
Copy link
Contributor Author

我还没写 mock ,我想想。
mock好麻烦。

@unknowissue
Copy link
Contributor Author

咦,oracle_test_export_db 和 oracle_test_export_instance 这两项咋不测试呢。。。

@unknowissue
Copy link
Contributor Author

嘶, oracle_test_export_db 和 oracle_test_export_instance 不测试
唔,就这样吧。。。
谁拉取测试看看吧。

requirements.txt Outdated
@@ -26,4 +26,5 @@ uvloop==0.14.0
httptools==0.1.1
uvicorn==0.12.2
pycryptodome==3.10.1
pandas
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指定下版本,避免出现不兼容的升级

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指定下版本,避免出现不兼容的升级

好了

@hhyo hhyo merged commit ee58c29 into hhyo:master Feb 17, 2022
@hhyo hhyo mentioned this pull request Feb 17, 2022
@unknowissue unknowissue deleted the oracle-metadata-dispaly branch February 24, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants