查询超时也要记录日志 #2110
Merged
查询超时也要记录日志 #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2110 +/- ##
==========================================
- Coverage 75.24% 75.24% -0.01%
==========================================
Files 105 105
Lines 15182 15183 +1
==========================================
Hits 11424 11424
- Misses 3758 3759 +1
☔ View full report in Codecov by Sentry. |
LeoQuote
reviewed
Apr 3, 2023
| hit_rule=query_result.mask_rule_hit, | ||
| masking=query_result.is_masked, | ||
| ) | ||
| query_log.save() |
There was a problem hiding this comment.
你好, 要不放进 finally 里面吧, 这样即使查询异常也有查询记录
There was a problem hiding this comment.
你好，我觉得暂时没有必要记录查询异常情况，可以把查询过程中超时或者被kill处理，出现查询错误等情况记录下即可
There was a problem hiding this comment.
调整后这个记录的位置已经是记录了异常情况，比如语法错误等
以前是query_result.error不存在才记录
hhyo
reviewed
May 14, 2023
| var extraInfo = tabs[i].children[1].innerHTML+"|"+e.length; | ||
| var instance_name = $("#instance_name").val() | ||
| var db_name =$("#db_name").val() | ||
| var extraInfo = instance_name+"/"+db_name+"|"+$(tabs[i].children[1]).attr('sql_cache')+"|"+e.length; |
There was a problem hiding this comment.
当前版本中记录下载的审计日志，获取sql语句是空的，只记录了下载的行数，具体是哪个sql的下载是不知道的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
查询超时也要记录日志