Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-13884 Order.reverse() contract #3271

Merged

Conversation

seregamorph
Copy link
Contributor

@seregamorph seregamorph commented Feb 28, 2020

https://hibernate.atlassian.net/browse/HHH-13884

backport for #3272

javax.persistence.criteria.Order.reverse() method javadoc explicitly declares that reverse() should return new instance.

@seregamorph seregamorph force-pushed the HHH-13884-order-reverse-contract branch from ad82400 to 12060d1 Compare February 28, 2020 13:44
@NathanQingyangXu
Copy link
Contributor

Seems a good catch. JPA does require to return a new Order instance. The implementation is based on fluent API design. One of the concern is this code change might break our client's code, but if JPA dictates it, it might be the way we should go.

@seregamorph
Copy link
Contributor Author

@NathanQingyangXu any objections to merge it?

@NathanQingyangXu
Copy link
Contributor

I have approved but I have no rights to merge it for I am not a team member.

@seregamorph
Copy link
Contributor Author

@beikov any chance to accept this? If no, let's close it

@beikov beikov merged commit 9934baf into hibernate:master Sep 28, 2020
@seregamorph seregamorph deleted the HHH-13884-order-reverse-contract branch September 28, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants