-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Block Range API #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just a couple things that can be improved on (see comments below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing: please make sure that the getStatus
API itself can never be disabled. It should always be possible to check on a node's status.
Operator can still put getStatus in their blocklist, but it won't be respected. getStatus will still report getStatus as being blocked.
Resolved in 7c2b045. While the operator can still place it in the blocklist, the block of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now, thanks!
Allows for getting information on blocks in a range with a single call.
This is a very heavy api and should not be enabled on public nodes. To make sure this doesn't happen, a config feature has been added to allow disabling certain RPC methods. The default config disables the new method.