Supports witnesses using domains for their nodes in addition to IPs #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishi556
changed the title
bt-cryptomancer
requested changes
Feb 19, 2023
bt-cryptomancer
requested changes
May 8, 2023
bt-cryptomancer
approved these changes
May 24, 2023
|
We ran this over the weekend, on a testnet(and plan to leave running until tomorrow at least) and saw it all go smoothly. Invalid cases(some inadvertently) were attempted as well, and all failed. I'm pretty comfortable releasing this, if you'd like to join in the testing, feel free to. For release, we'll need a new tagged release first that witnesses upgrade to(due to changes in plugins/P2P), and then the contract should be deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.