Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Data Leak #27

Merged
merged 4 commits into from
May 15, 2023
Merged

Fix Data Leak #27

merged 4 commits into from
May 15, 2023

Conversation

Rishi556
Copy link
Contributor

No description provided.

@Rishi556 Rishi556 changed the base branch from main to qa April 30, 2023 23:17
@Rishi556 Rishi556 marked this pull request as ready for review April 30, 2023 23:18
bt-cryptomancer
bt-cryptomancer previously requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@bt-cryptomancer bt-cryptomancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are conflicts to resolve after I merged #25 and #26

Also, is there a reason you upgraded the versions of body-parser and express? I think it's fine, but just curious if it's related to this fix or you thought it was important to do so for some other reason.

@Rishi556
Copy link
Contributor Author

I tried updating them initially to see if it potentially fixed it and didn’t realize it got committed. It shouldn’t hurt/help anything and probably just better to bump them hp for any improvements in them

@eonwarped eonwarped merged commit 003c1f5 into hive-engine:qa May 15, 2023
@Rishi556 Rishi556 deleted the invalidrequest-fix branch May 15, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bt-cryptomancer bt-cryptomancer bt-cryptomancer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rishi556 @bt-cryptomancer @eonwarped