Restore default witness_action.js behaviour #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not force checking divergence by default against anyone, as that might introduce unwanted misunderstanding about what means to check for divergence against a node.
|
Pinging you @Rishi556 as this was a feature you kindly brought to us all. And its super useful, but only now thought about this. |
|
That's a fair thought. I don't care either way, having the option is nice and as long as those who want to have a way to do it. Can you change your merge target to the |
Rishi556
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up for discussion but, in my view we should not force checking divergence by default against anyone, as that might introduce unwanted misunderstanding about what means to check for divergence against a node.
The option is very helpful and one can still check for divergence upon using the option against specific nodes. But because many might not even check this property, defaulting to a specific node might introduce a targeted behavior without many noticing.