Update to dual rpc on find divergent block and restore parital #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge qa and bump version to 1.9.1
Rishi556
changed the title
|
This method of API access is not guaranteed to work as it's system dependent (it will not work for the Engine team's primary & backup nodes for example). Putting this PR into draft status for now, and will close it in a week if there is no further discussion on it. |
|
I think all nodes supporting this type of calls should be a bare minimum to be classified as a public node. It allows for some handy features, most importantly of which is batching contract and blockchain calls into 1 request. |
|
Been longer than a week lol. I think supporting this type of call should be a change that the engine team makes. |
|
This works when you add a slash to the main engine node in the default value, I am okay with this if that gets added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not using this, using the
-nargument to specify a node requires that the trailing/be added. With this implemented, it won't matter either way.