[Consensus] Support Node 20 #46
Conversation
|
@Rishi556 I've converted this to draft status as I'm not comfortable making such a fundamental change for the time being. We can revisit this in September when I'm back from summer travels. |
|
I do think we should try and update as new releases are made, especially since Node now has a team dedicated to performance. Doing updates in smaller batches and keeping up will make it a lot easier than trying to fix support for a few node versions at once which might have many breaking changes, vs doing 1 at a time might lead to just a few. BTW this will need to be changed before deployment to change the block num. |
|
@bt-cryptomancer Can you take a look at this. We'll have to change block number but I'd like to get this one merged in before Node 22 gets released in about 2 months |
|
Node 16 is EOL(and is approaching 6 months of EOL) as well, thoughts on dropping it from the test matrix? |
deferring to @bt-cryptomancer |
|
@Rishi556 I'm fine to have Node 16 removed from the test matrix. If we're going to do that, let's also update the minimum node version in the package.json to 18+ I will update the trigger block number after merging this to QA and after other consensus breaking changes are merged in. |
Update minimum engine version to latest 18
|
Looks good now, but conflict needs to be resolved before merging. |
bt-cryptomancer
dismissed
eonwarped’s stale review
requested changes have been made
Adds support for Node.JS 20.
The error message logged during deployment needed to be changed from using node's error message to a custom error message as node's internal changed how the message would be spit out. For now I put the deployment date as after hive block
76149072which is approximately July 25th.Old message from node:
SyntaxError: Unexpected identifierNew message from node:
SyntaxError: Unexpected identifier 'CODE'To handle older blocks, anything with "SyntaxError: Unexpected identifier" forcibly becomes just "SyntaxError: Unexpected identifier", removing the extra stuff which stated what was the unidentified variable.