bump axios, dhive, express and loglevel #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rishi556 increasing version numbers of dependencies is always something that I am quite wary about due to the possibility of unforeseen side effects and / or breaking changes. Have you been running this on your witness node with no issues? I'd like to see it being used on a node for at least a month or so before merging. |
|
I don't have a witness anymore so can't run it there. Maybe one of the others wants to run it? None of these should cause any issues though as they aren't involved in the smart contracts stuff. I will be running this on a backup RPC node for some time though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some dep bumps of safe deps that don't affect the smart-contract engine. Axios needs a patch due to this issue: axios/axios#5333 which can be reverted once this(or something else that fixes the issue) is merged in: axios/axios#5731