Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest <- beta #21

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

latest <- beta #21

wants to merge 2 commits into from

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Jul 25, 2024

note!! there are currently ts build issues:

> @homebridge/[email protected] build
> rimraf ./dist && tsc --project tsconfig.json && tsc --project tsconfig.ui.json

src/ui.mock.ts:75:10 - error TS2416: Property 'createForm' in type 'MockHomebridgePluginUi' is not assignable to the same property in base type 'IHomebridgePluginUi'.
  Type '(schema: any, data: any) => MockHomebridgeUiFormHelper' is not assignable to type '(schema: PluginFormSchema, data: any, submitButton?: string | undefined, cancelButton?: string | undefined) => IHomebridgeUiFormHelper'.
    Type 'MockHomebridgeUiFormHelper' is not assignable to type 'IHomebridgeUiFormHelper'.

75   public createForm(schema, data) {
            ~~~~~~~~~~

src/ui.mock.ts:76:43 - error TS2345: Argument of type 'this' is not assignable to parameter of type 'IHomebridgePluginUi'.
  Type 'MockHomebridgePluginUi' is not assignable to type 'IHomebridgePluginUi'.
    The types returned by 'createForm(...)' are incompatible between these types.
      Type 'MockHomebridgeUiFormHelper' is missing the following properties from type 'IHomebridgeUiFormHelper': onSubmit, onCancel

76     return new MockHomebridgeUiFormHelper(this, schema, data);
                                             ~~~~


Found 2 errors in the same file, starting at: src/ui.mock.ts:75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant