Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: allow the default camera resolution to be set (#347)
* Fix IOS Bundle ID issue for Xcode Archive/App uploads * -Fix flipped front camera on mobile -Allow default resolution of camera to be set to 1280x720 for devices that have high resolution cameras (prevents crash behaviour on mobile) * Revert "Fix IOS Bundle ID issue for Xcode Archive/App uploads" This reverts commit a13a722. * Revert "-Fix flipped front camera on mobile" This reverts commit fea330c. * Use a manually set default resolution within 300px to choose the nearest default resolution on mobile -Prevents huge performance issues on phones with high resolution cameras when using the sample app * Apply suggestions from code review Co-authored-by: Junrou Nishida <[email protected]> * Refactor to improve the default width functionality - tested * Check if default resolution matches first, if not fall back to use a resolution within 300px, else return the first resolution found * Update Assets/Mediapipe/Samples/Common/Scripts/ImageSource/WebCamSource.cs Co-authored-by: Junrou Nishida <[email protected]> * Move resolution switching from ImageSource to WebCamSource exclusively * Revert ImageConfig changes to allow default active resolution to populate resolution dropdown * Implemented resolution comparer * Ensure lf file ending again * Remove redundant boolean * Update tooltip text - Update Assets/Mediapipe/Samples/Common/Scripts/ImageSource/WebCamSource.cs Co-authored-by: Junrou Nishida <[email protected]> * Make _preferableDefaultWidth private - Update Assets/Mediapipe/Samples/Common/Scripts/ImageSource/WebCamSource.cs Co-authored-by: Junrou Nishida <[email protected]> * Remove unnecessary UnityEngine import * Move ResolutionStructComparer to the end of WebCamSource.cs * Ensure all lf maintained Co-authored-by: RobFarthing_EPM <[email protected]> Co-authored-by: Junrou Nishida <[email protected]>
- Loading branch information