revert a breaking change (#511)

homuler · Apr 5, 2022 · e1a908d · e1a908d
1 parent 81fe7f8
commit e1a908d
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/Packages/com.github.homuler.mediapipe/Runtime/Scripts/Framework/Packet/Packet.cs b/Packages/com.github.homuler.mediapipe/Runtime/Scripts/Framework/Packet/Packet.cs
@@ -114,9 +114,7 @@ protected override void DeleteMpPtr()
       UnsafeNativeMethods.mp_Packet__At__Rt(mpPtr, timestamp.mpPtr, out var packetPtr).Assert();
       GC.KeepAlive(timestamp);
 
-      var packet = Create<TPacket>(packetPtr, true);
-      Dispose();
-      return packet;
+      return Create<TPacket>(packetPtr, true);
     }
   }
 }
diff --git a/Packages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/BoolPacketTest.cs b/Packages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/BoolPacketTest.cs
@@ -101,7 +101,7 @@ public void At_ShouldReturnNewPacketWithTimestamp()
           Assert.AreEqual(newPacket.Timestamp(), newTimestamp);
         }
 
-        Assert.True(packet.isDisposed);
+        Assert.AreEqual(packet.Timestamp(), timestamp);
       }
     }
     #endregion

diff --git a/...ages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/FloatArrayPacketTest.cs b/...ages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/FloatArrayPacketTest.cs
@@ -105,7 +105,7 @@ public void At_ShouldReturnNewPacketWithTimestamp()
           Assert.AreEqual(newPacket.Timestamp(), newTimestamp);
         }
 
-        Assert.True(packet.isDisposed);
+        Assert.AreEqual(packet.Timestamp(), timestamp);
       }
     }
     #endregion

diff --git a/Packages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/FloatPacketTest.cs b/Packages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/FloatPacketTest.cs
@@ -89,7 +89,7 @@ public void At_ShouldReturnNewPacketWithTimestamp()
           Assert.AreEqual(newPacket.Timestamp(), newTimestamp);
         }
 
-        Assert.True(packet.isDisposed);
+        Assert.AreEqual(packet.Timestamp(), timestamp);
       }
     }
     #endregion

diff --git a/...ages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/ImageFramePacketTest.cs b/...ages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/ImageFramePacketTest.cs
@@ -113,7 +113,7 @@ public void At_ShouldReturnNewPacketWithTimestamp()
           Assert.AreEqual(newPacket.Timestamp(), newTimestamp);
         }
 
-        Assert.True(packet.isDisposed);
+        Assert.AreEqual(packet.Timestamp(), timestamp);
       }
     }
     #endregion

diff --git a/Packages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/StringPacketTest.cs b/Packages/com.github.homuler.mediapipe/Tests/EditMode/Framework/Packet/StringPacketTest.cs
@@ -117,7 +117,7 @@ public void At_ShouldReturnNewPacketWithTimestamp()
           Assert.AreEqual(newPacket.Timestamp(), newTimestamp);
         }
 
-        Assert.True(packet.isDisposed);
+        Assert.AreEqual(packet.Timestamp(), timestamp);
       }
     }
     #endregion