Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove deprecated APIs #1119

Merged
merged 1 commit into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ public class CalculatorGraph : MpResourceHandle
{
public delegate StatusArgs NativePacketCallback(IntPtr graphPtr, int streamId, IntPtr packetPtr);
public delegate void PacketCallback(Packet packet);
[Obsolete("Use non-generic PacketCallback instead")]
public delegate void PacketCallback<TPacket, TValue>(TPacket packet) where TPacket : Packet<TValue>;

public CalculatorGraph() : base()
{
Expand Down Expand Up @@ -77,33 +75,6 @@ public void ObserveOutputStream(string streamName, int streamId, NativePacketCal
AssertStatusOk(statusPtr);
}

[Obsolete("Use non-generic ObserveOutputStream")]
public void ObserveOutputStream<TPacket, TValue>(string streamName, PacketCallback<TPacket, TValue> packetCallback, bool observeTimestampBounds, out GCHandle callbackHandle) where TPacket : Packet<TValue>, new()
{
NativePacketCallback nativePacketCallback = (IntPtr graphPtr, int streamId, IntPtr packetPtr) =>
{
try
{
var packet = Packet<TValue>.Create<TPacket>(packetPtr, false);
packetCallback(packet);
return StatusArgs.Ok();
}
catch (Exception e)
{
return StatusArgs.Internal(e.ToString());
}
};
callbackHandle = GCHandle.Alloc(nativePacketCallback, GCHandleType.Pinned);

ObserveOutputStream(streamName, 0, nativePacketCallback, observeTimestampBounds);
}

[Obsolete("Use non-generic ObserveOutputStream")]
public void ObserveOutputStream<TPacket, TValue>(string streamName, PacketCallback<TPacket, TValue> packetCallback, out GCHandle callbackHandle) where TPacket : Packet<TValue>, new()
{
ObserveOutputStream(streamName, packetCallback, false, out callbackHandle);
}

public void ObserveOutputStream(string streamName, PacketCallback packetCallback, bool observeTimestampBounds, out GCHandle callbackHandle)
{
NativePacketCallback nativePacketCallback = (IntPtr graphPtr, int streamId, IntPtr packetPtr) =>
Expand All @@ -129,16 +100,6 @@ public void ObserveOutputStream(string streamName, PacketCallback packetCallback
ObserveOutputStream(streamName, packetCallback, false, out callbackHandle);
}

[Obsolete("Use non-generic AddOutputStreamPoller")]
public OutputStreamPoller<T> AddOutputStreamPoller<T>(string streamName, bool observeTimestampBounds = false)
{
UnsafeNativeMethods.mp_CalculatorGraph__AddOutputStreamPoller__PKc_b(mpPtr, streamName, observeTimestampBounds, out var statusPtr, out var pollerPtr).Assert();

GC.KeepAlive(this);
AssertStatusOk(statusPtr);
return new OutputStreamPoller<T>(pollerPtr);
}

public OutputStreamPoller AddOutputStreamPoller(string streamName, bool observeTimestampBounds = false)
{
UnsafeNativeMethods.mp_CalculatorGraph__AddOutputStreamPoller__PKc_b(mpPtr, streamName, observeTimestampBounds, out var statusPtr, out var pollerPtr).Assert();
Expand Down Expand Up @@ -197,16 +158,6 @@ public bool HasError()
return SafeNativeMethods.mp_CalculatorGraph__HasError(mpPtr);
}

[Obsolete("Use non-generic AddPacketToInputStream instead")]
public void AddPacketToInputStream<T>(string streamName, Packet<T> packet)
{
UnsafeNativeMethods.mp_CalculatorGraph__AddPacketToInputStream__PKc_Ppacket(mpPtr, streamName, packet.mpPtr, out var statusPtr).Assert();
packet.Dispose(); // respect move semantics

GC.KeepAlive(this);
AssertStatusOk(statusPtr);
}

public void AddPacketToInputStream(string streamName, Packet packet)
{
UnsafeNativeMethods.mp_CalculatorGraph__AddPacketToInputStream__PKc_Ppacket(mpPtr, streamName, packet.mpPtr, out var statusPtr).Assert();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,41 +43,4 @@ public int QueueSize()
return result;
}
}

[Obsolete("Use non-generic OutputStreamPoller instead")]
public class OutputStreamPoller<T> : MpResourceHandle
{
public OutputStreamPoller(IntPtr ptr) : base(ptr) { }

protected override void DeleteMpPtr()
{
UnsafeNativeMethods.mp_OutputStreamPoller__delete(ptr);
}

public bool Next(Packet<T> packet)
{
UnsafeNativeMethods.mp_OutputStreamPoller__Next_Ppacket(mpPtr, packet.mpPtr, out var result).Assert();

GC.KeepAlive(this);
return result;
}

public void Reset()
{
UnsafeNativeMethods.mp_OutputStreamPoller__Reset(mpPtr).Assert();
}

public void SetMaxQueueSize(int queueSize)
{
UnsafeNativeMethods.mp_OutputStreamPoller__SetMaxQueueSize(mpPtr, queueSize).Assert();
}

public int QueueSize()
{
UnsafeNativeMethods.mp_OutputStreamPoller__QueueSize(mpPtr, out var result).Assert();

GC.KeepAlive(this);
return result;
}
}
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading