getContents() quoted-printable EOL patch #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a bug in getContents() when part is encoded with quoted-printable.
When calling Horde_Mime_Part::parseMessage() at the beginning all EOL characters are converted to CR instead of CRLF but unfortunately it messes quoted-printable encoding which required CRLF.
As it states in comments CR is required internally so I've added additional backwards conversion only to stream contents of parts encoded to quoted-printable.
When using Horde_Mime_Part::getRawPartText() which for some reason uses CRLF I can manually decode quoted-printable just fine without any other conversions.
I've run several test and it's working fine.
Simple test case:
Assuming that test.eml is test email message and in 1.2 part is image encoded with quoted-printable.