Merged branch bugfix/work-on-archival-of-big-plan-activitiies into de…

…velop
horia141 · Jun 17, 2024 · 6ae3f88 · 6ae3f88
1 parent 992fb7f
commit 6ae3f88
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 16 deletions.
diff --git a/src/core/jupiter/core/use_cases/time_plans/activity/archive.py b/src/core/jupiter/core/use_cases/time_plans/activity/archive.py
@@ -55,22 +55,23 @@ async def _perform_transactional_mutation(
                 source=InboxTaskSource.BIG_PLAN,
                 big_plan_ref_id=activity.target_ref_id,
             )
-            inbox_task_activities = await uow.get_for(
-                TimePlanActivity
-            ).find_all_generic(
-                parent_ref_id=activity.parent_ref_id,
-                allow_archived=False,
-                target=TimePlanActivityTarget.INBOX_TASK,
-                target_ref_id=[it.ref_id for it in inbox_tasks],
-            )
-            for inbox_task_activity in inbox_task_activities:
-                await generic_archiver(
-                    context.domain_context,
-                    uow,
-                    progress_reporter,
-                    TimePlanActivity,
-                    inbox_task_activity.ref_id,
+            if len(inbox_tasks) > 0:
+                inbox_task_activities = await uow.get_for(
+                    TimePlanActivity
+                ).find_all_generic(
+                    parent_ref_id=activity.parent_ref_id,
+                    allow_archived=False,
+                    target=TimePlanActivityTarget.INBOX_TASK,
+                    target_ref_id=[it.ref_id for it in inbox_tasks],
                 )
+                for inbox_task_activity in inbox_task_activities:
+                    await generic_archiver(
+                        context.domain_context,
+                        uow,
+                        progress_reporter,
+                        TimePlanActivity,
+                        inbox_task_activity.ref_id,
+                    )
 
         await generic_archiver(
             context.domain_context,

diff --git a/src/webui/app/routes/workspace/time-plans/$id.tsx b/src/webui/app/routes/workspace/time-plans/$id.tsx
@@ -327,7 +327,7 @@ export default function TimePlanView() {
                 actions={[
                   NavMultipleCompact(
                     NavSingle(
-                      "New Inbox Tasks",
+                      "New Inbox Task",
                       `/workspace/inbox-tasks/new?timePlanReason=for-time-plan&timePlanRefId=${loaderData.timePlan.ref_id}`
                     ),
                     NavSingle(