added chapter (provisionally 23) on time patterns and author note #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrbrmstr
reviewed
May 12, 2018
|
|
||
| ```{r 23_graph, message=FALSE, warning=FALSE, cache=TRUE, fig.width=8, fig.height=6} | ||
| ggplot(cyclic, aes(x=week_day, y= single_day)) + | ||
| geom_jitter(width = 0.1, alpha=0.3, size=0.3) + theme_minimal() + |
There was a problem hiding this comment.
Would you be amenable to adding a library(ggbeeswarm) and adding another graph plot section showing it? (i.e. same ggplot() chain but using geom_quasirandom(width = 0.1, alpha=0.3, size=0.3)?
There was a problem hiding this comment.
perhaps even a width = 0.3 for that quasirandom suggestion
There was a problem hiding this comment.
That visualisation looks great. Not one I had come across before, but that is part of the awesomeness of the sharing of the community & the way new perspectives show what is possible.
|
This looks 👍 ! I added one comment/suggestion but this will be helpful to folks (especially ensuring timezone b/c I tend to be a bit lazy and let things float in UTC land :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a chapter 23 Rmd for a time based analysis (and author note as you suggested), but I didn't add the knitted files as I was more comfortable with you reviewing it first (as the primary author)