Switch from MM:SS to HH:MM:SS duration representation if needed. #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkfdn
approved these changes
Feb 16, 2023
src/utils.rs
Outdated
Comment on lines
36
to
40
| if hours > 0 { | ||
| formated_time.push_str(&format!("{hours}:")); | ||
| } | ||
| if hours > 0 { | ||
| formated_time.push_str(&format!("{minutes:02}:")); |
There was a problem hiding this comment.
Oh oops. I was thinking in terms of the steps that had to be applied (hours, minutes, seconds) to get to the representation. Didn't consider moving those together. 😄
|
No one saw a thing leaves in shame |
|
Merged, thanks again ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the same logic to durations as the native Spotify client:
0:00
0:01
0:23
0:20
1:00
10:02
1:00:00
1:01:01
...
It applies it to all the places where currently the old method was used (statusbar left and right, track durations, episode durations).
closes #1048