let everyone have covers in their notifications #1053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this check exists, because at least to my understanding the cover feature is only for drawing the covers in the terminal.
I tested this and it displayed the covers in my notifications without needing the "cover" feature, at least i think the cover feature isn't automatically enabled when i compile it with
cargo build
.And i personally don't see a reason why covers shouldn't be displayed for everyone. I don't want to use the "cover" feature but having the cover in my notifications is a thing i want.