commands: Adding "disconnect" command to force socket shutdown #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inemajo
force-pushed
the
add_disconnect_command
branch
from
b4b76c3
to
eb989e9
Compare
hrkfdn
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Thanks! Generally this looks good to me. While it is technically more correct to call it disconnect, I'm wondering if we should go with reconnect connect instead as disconnect may suggest the application will close? WDYT?
Also, I haven't really tested this yet, but what is your experience with dropping the connection and have it reconnect. Does ncspot recover from it nicely or is there some extra work needed?
hrkfdn
force-pushed
the
add_disconnect_command
branch
from
f20a91c
to
e2214ca
Compare
|
Will merge it as |
This was referenced Feb 26, 2023
|
Yes it's better to call it reconnect, thanks for the merge ! |
hrkfdn
added a commit
to ThomasFrans/ncspot
that referenced
this pull request
Feb 28, 2023
…n#1057) * commands: Adding "disconnect" command to force socket shutdown * Rename to `reconnect` * Add documentation to README Related to: hrkfdn#628 hrkfdn#1033 --------- Co-authored-by: Henrik Friedrichsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pull request add a "disconnect" command, usefull when your connection change and you want to force closing the socket for reconnect