-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add clippy and update toolchain install action. #1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for tackling this. I have some minor comments below.
I'll update the things you mentioned (or you can do it if you prefer). |
4705562
to
e369994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged, thank you! :)
I think you might have to clear out the current job cache once (the ones used in the last while, as I don't remember if there is a clear all button). I had some problems where the clippy and build files were using the same cache tag which isn't correct. |
Thanks for the heads up, I'll update the Cargo.lock via a dependency update which should change the cache key, right? |
target
directory anyways.I hope this is ok. This is only my second GitHub CI config I've worked on so if anything isn't right, I'll happily change it 🙂
The first run without any caches took around 10m for me, subsequent runs take around 3m40s as long as the
Cargo.lock
file doesn't change (which invalidates the dependency artifact caches).Also it might be necessary to manually delete the latest caches (the ones that were used in the last while) as I don't think they will be updated with the target directory otherwise...
closes #1051