Disable autojump for add to playlist dialog. #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autojump seems to take precedence over regular keys, which isn't the wanted behavior, especially when there are playlists in the list that contain some of the most common Vim keybindings. For example when there is a playlist called 'jazz', pressing `j` will jump to that playlist instead of going down. This commit disables autojump for now. If search inside the add to playlist dialog would be a wanted feature, it could be implemented using the default Vim search button `/` which would work the same way as searching in other lists works right now.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autojump seems to take precedence over regular keys, which isn't the wanted behavior, especially when there are playlists in the list that contain some of the most common Vim keybindings. For example when there is a playlist called 'jazz', pressing
jwill jump to that playlist instead of going down.This commit disables autojump for now. If search inside the add to playlist dialog would be a wanted feature, it could be implemented using the default Vim search button
/which would work the same way as searching in other lists works right now.closes #881