Emulate double click to play items. #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the behavior of `ListView` to treat a click on an item that is already selected as a double click. It allows the user to play songs (not episodes since currently it's not possible to determine if a `ListItem` is an episode) by "double clicking" them. It is a bit of a hack, but it works pretty well. A possible downside is that when people that don't like mouse integration in a TUI click to focus the terminal window, it could jump to the song they clicked if that happened to be the selected one.
|
I don't know if this is an acceptable approach to implement this feature request, as there is the problem explained in the commit message. I don't think this is too bad of a problem personally since clicking anywhere already highlights songs. A configuration option to disable the mouse could be added for people that prefer no mouse integration in TUI applications. |
|
Merged, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behavior of
ListViewto treat a click on an item that is already selected as a double click. It allows the user to play songs (not episodes since currently it's not possible to determine if aListItemis an episode) by "double clicking" them. It is a bit of a hack, but it works pretty well. A possible downside is that when people that don't like mouse integration in a TUI click to focus the terminal window, it could jump to the song they clicked if that happened to be the selected one.closes #917