Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statusbar: update nerdfont glyphs #1093

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Conversation

cfebs
Copy link
Contributor

@cfebs cfebs commented Mar 18, 2023

As of ryanoasis/nerd-fonts#1096 nf-mdi* glyphs are marked obsolete in nerd-fonts upstream

Update the glyphs to non-deprecated nf-fa* counterparts

Details

The current glphys used in ncspot are marked obsolete:

play pause stop
image image image

From https://www.nerdfonts.com/cheat-sheet

An added bonus to the update may be a bugfix too! There is an issue opened here: #824 which is similar to my experience.

Here is what the glyphs look like for me just echoing the unicode (kitty 0.27.1, TERM=xterm-kitty, font_family JetBrains Mono, my installed nerd-font packages)

echo -e 'CURRENT:\n\uf909\n\uf8e3\n\uf9da\nNEW:\n\uf04b\n\uf04c\n\uf04d'

image

and here is a comparison from my "current" ncspot distro (arch) ncspot (0.12.0) vs. "new" local release build:

current

image

new

image

As of ryanoasis/nerd-fonts#1096
nf-mdi* glyphs are marked obsolete in nerd-fonts upstream

Update the glyphs to non-deprecated nf-fa* counterparts
@hrkfdn hrkfdn enabled auto-merge (rebase) March 18, 2023 23:21
Copy link
Owner

@hrkfdn hrkfdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! LGTM!

@hrkfdn hrkfdn merged commit dcfb820 into hrkfdn:main Mar 18, 2023
@cfebs cfebs deleted the update-nf-media-glyphs branch March 20, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants