Rewrite MPRIS implementation using zbus #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkfdn
force-pushed
the
hf/mpris_zbus
branch
3 times, most recently
from
9181f7c
to
38151b7
Compare
The initial DBus implementation was getting harder to maintain and `zbus` offers some nice convenience features that should make our MPRIS implementation cleaner. For now this only implements the `org.mpris.MediaPlayer2` interface which does not do much. Should help with #1103
- `PlaybackStatus` - `PlaybackRate` - `Volume` (get/set)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial DBus implementation was getting harder to maintain and
zbusoffers some nice convenience features that should make our MPRIS implementation cleaner.For now this only implements the
org.mpris.MediaPlayer2interface which does not do much.Should help with #1103