fix: command line multi-byte prefix panic #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was aware of this bug already but didn't submit a patch as I didn't think users could edit the command. I forgot that users can move 'in front of the prefix', which can cause a crash when they submit a command that contains a multi-byte character as the prefix, like '🔥' for example. |
Don't index into the command line command as the prefix can be altered by the user and therefore be a multi-byte unicode character.
ThomasFrans
force-pushed
the
fix-command-line-unicode-panic
branch
from
347ca84
to
3e91294
Compare
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't index into the command line command as the prefix can be altered by the user and therefore be a multi-byte unicode character.