Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve release build options #1199

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

ThomasFrans
Copy link
Contributor

closes #1192

@ThomasFrans
Copy link
Contributor Author

I also added the codegen-units options which doesn't change anything except for code quality of the release builds (similar to lto). I added an optimized profile for testing performance as it has the same speed as the release profile, but takes way less time to compile. Neither of these options should change any behavior or debugging info.

@hrkfdn hrkfdn merged commit 03cfd4d into hrkfdn:main Jun 13, 2023
5 checks passed
@hrkfdn
Copy link
Owner

hrkfdn commented Jun 13, 2023

Merged, thanks!

@ThomasFrans ThomasFrans deleted the lazy-tremendous-optimization branch June 13, 2023 21:23
@juippis
Copy link

juippis commented Jul 24, 2023

I noticed the buildtime for 0.13.4 has tripled compared to 0.13.3. If I revert this commit, it goes back to "normal".

Not a big deal as ncspot doesn't take too long to build anyway, just typing what I observed and if someone else sees the same :)

EDIT: I see this was discussed in #1192 already.

@ThomasFrans
Copy link
Contributor Author

I hoped that most people would get release binaries from their package managers so they wouldn't notice this change. Other people can either choose the longer compilation time or compile with the 'optimized' profile, which results in the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable link time optimization for smaller builds
3 participants