Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused screenchange variable #1205

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

ThomasFrans
Copy link
Contributor

The screenchange member variable on Layout didn't seem to be used for anything except for debugging. A comment in on_layout makes it seem like it wasn't meant to be used for debugging purposes but for actual functionality that wasn't implemented.

The `screenchange` member variable on `Layout` didn't seem to be used
for anything except for debugging. A comment in `on_layout` makes it
seem like it wasn't meant to be used for debugging purposes but for
actual functionality that wasn't implemented.
@ThomasFrans
Copy link
Contributor Author

Back with more insane space savings, a whole 1 byte this time 😝

I was adding some documentation to Layout and wondered what this variable was for so looked it up, and except for the debug line, I don't see what it does. I think it might have been for future functionality that was never implemented. If it was for debugging purposes only, it makes sense, but a comment mentioned it was also used to let views know the active focus view was changed, something I can't find an implementation for. I could be wrong.

I just thought I'd remove it to clean up the code and avoid confusion about what this variable is for.

@hrkfdn hrkfdn merged commit 0c93caf into hrkfdn:main Jun 18, 2023
5 checks passed
@hrkfdn
Copy link
Owner

hrkfdn commented Jun 18, 2023

Indeed, looks like a leftover. Merged, thanks!

@ThomasFrans ThomasFrans deleted the remove-unused-screenchange branch June 18, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants