Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reCAPTCHA v3, protection of BGP summary, and assorted bug fixes #46

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

vettamatt
Copy link

We needed reCAPTCHA v3 so have implemented this.
We found that the HSDN WHOIS wasn't working all the time, so switched this to RADb.
We implemented the ability to protect BGP summary information based upon the source IP address of the end user.

We have also fixed the following minor bugs that we encountered during development:

  • gitignore of logo files
  • Logo href URL
  • Removed the unused keys directory.

Peer developed with @mrjwilz

vettamatt and others added 14 commits January 31, 2022 10:29
- Added hiding of BGP summary and command line for public-facing LG's
- Added safe subnets array to permit some subnets to view peer information
- Added RADb to footer
- Stopped hyperlinks being added for private ASNs
- Minor code formatting changes
- Fixed AS information in traceroute
- Improved safe subnets message
Merg into test branch
reCAPTCHA v3 and assorted bug fixes
Peer developed with @mrjwilz
@@ -303,7 +393,7 @@ function load() {

$url = @parse_url($url);

$routing_instance = $_CONFIG['routers'][$router]['routing-instance'];
$routing_instance = isset($_CONFIG['routers']) AND isset($_CONFIG['routers'][$router]) AND isset($_CONFIG['routers'][$router]['routing-instance']) ? $_CONFIG['routers'][$router]['routing-instance'] : null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check, this code with PHP 8.1 always returns 1

$_CONFIG['showpeerinfo'] = 'TRUE';

/*
* If 'showpeerinfo' above is TRUE, and you would like to show BGP peer information to visitors from a specific IPv4 address or subnet, add the IPv4 address or subnet (in CIDR format) to the array below
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify the comment, according to the code 'showpeerinfo' should be "FALSE" to filter peer info based on visitors IP.

@scamp
Copy link

scamp commented Jan 13, 2024

Also please consider disabling reCaptcha for safe IP list, and disable AS_PATH manipulation, as it makes LG unusable.
Pushed proposed changes to vettagroup#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants