Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable minify in bundler #3

Merged
merged 1 commit into from
May 23, 2024
Merged

Add option to disable minify in bundler #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions opt/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,18 @@ func (App) CreateBundle() {
var deployment string
var rnDir string
var description string
var isMinifyDisabled bool

flag.StringVar(&targetVersion, "t", "", "Target version")
flag.StringVar(&appName, "n", "", "AppName")
flag.StringVar(&deployment, "d", "", "DeploymentName")
flag.StringVar(&rnDir, "p", "./", "React native project dir")
flag.StringVar(&description, "description", "", "Description")
flag.BoolVar(&isMinifyDisabled, "disable-minify", false, "Disable minify")
flag.Parse()

if targetVersion == "" || appName == "" || deployment == "" {
fmt.Println("Usage: code-push-go create_bundle -t <TargetVersion> -n <AppName> -d <deployment> -p <*Optional React native project dir> --description <*Optional Description>")
fmt.Println("Usage: code-push-go create_bundle -t <TargetVersion> -n <AppName> -d <deployment> -p <*Optional React native project dir> --description <*Optional Description> --disable-minify (*Optional)")
return
}
log.Println("Get app info...")
Expand Down Expand Up @@ -97,6 +99,12 @@ func (App) CreateBundle() {
if osName == "android" {
jsName = "index.android.bundle"
}

minify := "true"
if isMinifyDisabled {
minify = "false"
}

cmd := exec.Command(
"npx",
"react-native",
Expand All @@ -110,7 +118,9 @@ func (App) CreateBundle() {
"--entry-file",
"index.js",
"--platform",
osName)
osName,
"--minify",
minify)
cmd.Dir = rnDir
out, err := cmd.CombinedOutput()
if err != nil {
Expand Down
Loading